<html>
<head><meta charset="utf-8"><title>Some PRs are ripe for merge · t-cargo/PubGrub · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/index.html">t-cargo/PubGrub</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Some.20PRs.20are.20ripe.20for.20merge.html">Some PRs are ripe for merge</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="213054803"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Some%20PRs%20are%20ripe%20for%20merge/near/213054803" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Some.20PRs.20are.20ripe.20for.20merge.html#213054803">(Oct 12 2020 at 15:45)</a>:</h4>
<p>It seems to me that <a href="https://github.com/rust-lang/rust/issues/25">#25</a> (SPDX), <a href="https://github.com/rust-lang/rust/issues/32">#32</a> (package choice) and <a href="https://github.com/rust-lang/rust/issues/29">#29</a> (incompat redundancy) are ready to be merged if <span class="user-mention" data-user-id="340766">@Alex Tokarev</span>  agrees with these. Don't hesitate to merge those <span class="user-mention" data-user-id="340766">@Alex Tokarev</span> when you have time to review if they are ok.</p>



<a name="213075937"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Some%20PRs%20are%20ripe%20for%20merge/near/213075937" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Some.20PRs.20are.20ripe.20for.20merge.html#213075937">(Oct 12 2020 at 19:11)</a>:</h4>
<p>Indeed. I didn't want to merge any without you having a look. The only one I was brave enough to just merge was clickable documentation links, since it was very hard to do something wrong there.</p>
<p>I'll go over them now.</p>



<a name="213079091"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Some%20PRs%20are%20ripe%20for%20merge/near/213079091" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Some.20PRs.20are.20ripe.20for.20merge.html#213079091">(Oct 12 2020 at 19:46)</a>:</h4>
<p>I've reworded docs a little in <a href="https://github.com/rust-lang/rust/issues/32">#32</a> (details in the PR) and merged all 3.</p>



<a name="213079132"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Some%20PRs%20are%20ripe%20for%20merge/near/213079132" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Some.20PRs.20are.20ripe.20for.20merge.html#213079132">(Oct 12 2020 at 19:47)</a>:</h4>
<p>By the way, issues in this chat reference the core Rust repository. I wonder if we can change it in settings.</p>



<a name="213084682"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Some%20PRs%20are%20ripe%20for%20merge/near/213084682" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Some.20PRs.20are.20ripe.20for.20merge.html#213084682">(Oct 12 2020 at 20:44)</a>:</h4>
<p>I don't know the details but there was a conversation about it a while back:<br>
<a href="#narrow/stream/122653-zulip/topic/Clippy.20stream.3F">https://rust-lang.zulipchat.com/#narrow/stream/122653-zulip/topic/Clippy.20stream.3F</a></p>



<a name="213084864"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Some%20PRs%20are%20ripe%20for%20merge/near/213084864" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Some.20PRs.20are.20ripe.20for.20merge.html#213084864">(Oct 12 2020 at 20:47)</a>:</h4>
<p>pubgrub-rs#32</p>



<a name="213084915"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Some%20PRs%20are%20ripe%20for%20merge/near/213084915" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Some.20PRs.20are.20ripe.20for.20merge.html#213084915">(Oct 12 2020 at 20:47)</a>:</h4>
<p><a href="https://github.com/mpizenberg/pubgrub-rs/issues/32">mpizenberg/pubgrub-rs#32</a></p>



<a name="213084964"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Some%20PRs%20are%20ripe%20for%20merge/near/213084964" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Some.20PRs.20are.20ripe.20for.20merge.html#213084964">(Oct 12 2020 at 20:48)</a>:</h4>
<p>Yeah a general linkifier algorithm doesn't allow us to quickly write <code>#32</code> and be done with it.</p>



<a name="213085031"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Some%20PRs%20are%20ripe%20for%20merge/near/213085031" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Some.20PRs.20are.20ripe.20for.20merge.html#213085031">(Oct 12 2020 at 20:49)</a>:</h4>
<p>And typing <code>mpizenberg/pubgrub-rs#32</code>is slower than opening the issue and copying full link</p>



<a name="213085141"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Some%20PRs%20are%20ripe%20for%20merge/near/213085141" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Some.20PRs.20are.20ripe.20for.20merge.html#213085141">(Oct 12 2020 at 20:50)</a>:</h4>
<p>Do you have an access to "Organization Settings &gt; Linkifier" <span class="user-mention" data-user-id="120179">@Eh2406</span> ?</p>



<a name="213085287"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Some%20PRs%20are%20ripe%20for%20merge/near/213085287" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Some.20PRs.20are.20ripe.20for.20merge.html#213085287">(Oct 12 2020 at 20:52)</a>:</h4>
<p>I don't have access to that. <span class="user-mention" data-user-id="116015">@Alex Crichton</span> can you change the "Linkifier" rules for this stream? Or do you know who dose?</p>



<a name="213085811"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Some%20PRs%20are%20ripe%20for%20merge/near/213085811" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Some.20PRs.20are.20ripe.20for.20merge.html#213085811">(Oct 12 2020 at 20:58)</a>:</h4>
<p><a href="https://github.com/mpizenberg/pubgrub-rs/issues/32">pubgrub#32</a></p>



<a name="213085849"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Some%20PRs%20are%20ripe%20for%20merge/near/213085849" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Some.20PRs.20are.20ripe.20for.20merge.html#213085849">(Oct 12 2020 at 20:58)</a>:</h4>
<p>added a linkifier for <code>pubgrub#nnnn</code></p>



<a name="213085866"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Some%20PRs%20are%20ripe%20for%20merge/near/213085866" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Some.20PRs.20are.20ripe.20for.20merge.html#213085866">(Oct 12 2020 at 20:58)</a>:</h4>
<p>You are the best!</p>



<a name="213085878"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Some%20PRs%20are%20ripe%20for%20merge/near/213085878" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Some.20PRs.20are.20ripe.20for.20merge.html#213085878">(Oct 12 2020 at 20:58)</a>:</h4>
<p>it doesn't appear to be per-channel</p>



<a name="213085918"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Some%20PRs%20are%20ripe%20for%20merge/near/213085918" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Some.20PRs.20are.20ripe.20for.20merge.html#213085918">(Oct 12 2020 at 20:59)</a>:</h4>
<p><span class="user-mention" data-user-id="116015">@Alex Crichton</span> Thanks a bunch!</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>